Re: Memory leak in vac_update_relstats ?

Поиск
Список
Период
Сортировка
От Pavan Deolasee
Тема Re: Memory leak in vac_update_relstats ?
Дата
Msg-id 2e78013d0707201044p51ad174v3d55c9d875bba3ba@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Memory leak in vac_update_relstats ?  (Heikki Linnakangas <heikki@enterprisedb.com>)
Ответы Re: Memory leak in vac_update_relstats ?
Список pgsql-hackers

On 7/20/07, Heikki Linnakangas <heikki@enterprisedb.com> wrote:
Pavan Deolasee wrote:
> Are we leaking memory in vac_update_relstats ?
>
> /* Fetch a copy of the tuple to scribble on */
> ctup = SearchSysCacheCopy(RELOID,
>                              ObjectIdGetDatum(relid),
>                              0, 0, 0);
>
> This copy is not subsequently freed in the function.

It's palloc'd in the current memory context, so it's not serious. It'll
be freed at the end of the transaction, if not before that. That's the
beauty of memory contexts; no need to worry about small allocations like
that.

Right. But may be for code completeness, we should add that
missing heap_freetuple.

Thanks,
Pavan




--
Pavan Deolasee
EnterpriseDB     http://www.enterprisedb.com

В списке pgsql-hackers по дате отправления:

Предыдущее
От: "Pavan Deolasee"
Дата:
Сообщение: Re: MAXIMUM_ALIGNOF on Windows-32
Следующее
От: Tom Lane
Дата:
Сообщение: Re: Memory leak in vac_update_relstats ?