On 5/21/07, Pavan Deolasee <pavan.deolasee@gmail.com> wrote:
On 5/19/07, Heikki Linnakangas < heikki@enterprisedb.com > wrote:
Ah, sorry about that. For some reason my source tree was checked out
from the 8.2 branch, instead of CVS HEAD.
I looked at the patch. Not that I am very comfortable with this part
of the code, but nevertheless here are my comments:
Another problem that I noticed with the patch is that it disregards
the fillfactor while inserting the tuples. ISTM that this is a correct
behavior when a tuple is being inserted in the block to preserve cluster
ordering. But when the tuple is being inserted as a normal operation,
IMO we should respect the fillfactor.
The easiest way to reproduce this is to insert tuples sorted on the
cluster index key.
Thanks,
Pavan
--
EnterpriseDB
http://www.enterprisedb.com