On 02.03.22 21:49, samay sharma wrote:
> I think we are discussing two topics in this thread which in my opinion
> are orthogonal.
>
> (a) Should we make authentication methods pluggable by exposing these
> hooks? - These will allow users to add plugins of their own to support
> whatever auth method they like. One immediate use case (and what
> prompted me to start looking at this) is Azure Active Directory
> integration which is a common request from Azure customers. We could
> also, over time, move some of our existing auth methods into extensions
> if we don’t want to maintain them in core.
I don't think people are necessarily opposed to that.
At the moment, it is not possible to judge whether the hook interface
you have chosen is appropriate.
I suggest you actually implement the Azure provider, then make the hook
interface, and then show us both and we can see what to do with it.
One thing that has been requested, and I would support that, is that a
plugged-in authentication method should look like a built-in one. So
for example it should be able to register a real name, instead of
"custom". I think a fair bit of refactoring work might be appropriate
in order to make the authentication code more modular.