Re: May be BUG. Periodic burst growth of the checkpoint_req counter on replica.
От | Fujii Masao |
---|---|
Тема | Re: May be BUG. Periodic burst growth of the checkpoint_req counter on replica. |
Дата | |
Msg-id | 2bf011b9-4694-429d-bef4-cb18159a6cd6@oss.nttdata.com обсуждение исходный текст |
Ответ на | Re: May be BUG. Periodic burst growth of the checkpoint_req counter on replica. ("Anton A. Melnikov" <a.melnikov@postgrespro.ru>) |
Ответы |
Re: May be BUG. Periodic burst growth of the checkpoint_req counter on replica.
|
Список | pgsql-hackers |
On 2024/10/08 23:16, Anton A. Melnikov wrote: > > On 08.10.2024 15:42, Fujii Masao wrote: >> On 2024/09/30 12:26, Fujii Masao wrote: >>>>> In 0002.patch, I also modified the description of num_requested from >>>>> "Number of backend requested checkpoints" to remove "backend," as it can >>>>> be confusing since num_requested includes requests from sources other than >>>>> the backend. Thought? >>>> >>>> Agreed. E.g. from xlog. Then maybe changed it also in the function >>>> descriptions in the pg_proc.dat? For pg_stat_get_checkpointer_num_requested() >>>> and pg_stat_get_checkpointer_restartpoints_requested(). >>> >>> Yes, good catch! >> >> Patch attached. > > Looked at the patch. Just in case, checked that neither > “backend completed” nor “backend requested” were found anywhere else. > All is ok for me. Thanks for the review! Pushed. Regards, -- Fujii Masao Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION
В списке pgsql-hackers по дате отправления: