> On 11 Nov 2020, at 17:13, Jonathan S. Katz <jkatz@postgresql.org> wrote:
>
> On 11/11/20 11:11 AM, Tom Lane wrote:
>> "Jonathan S. Katz" <jkatz@postgresql.org> writes:
>>> On 11/11/20 10:43 AM, Tom Lane wrote:
>>>> I wonder if we should start passing "--nonet" to xmllint et al. I've
>>>> always felt that that silent reach into the internet was an anti-feature
>>>> on numerous grounds: it's slow, it's not very secure, it makes the results
>>>> uncertainly reproducible, etc etc etc.
>>
>>> It was still bugging out for me locally with --nonet, but that could
>>> also be operator error.
>>
>> The point of --nonet is that then you would *have to* install the DTDs
>> locally in order to build the docs.
>
> Yup, I had tried installing the DTDs locally, and clearly failed at it
> :) I also did not spend too much time trying to troubleshoot my failures.
Looking at config/docbook.m4 we check for the existence of the DTDs, but we
don't seem to use the findings in have_docbook? Shouldn't we do something like
the below:
--- a/src/Makefile.global.in
+++ b/src/Makefile.global.in
@@ -492,6 +492,7 @@ DBTOEPUB = @DBTOEPUB@
FOP = @FOP@
XMLLINT = @XMLLINT@
XSLTPROC = @XSLTPROC@
+have_docbook = @have_docbook@
..and then error out in the doc/ Makefiles for the relevant targets in case
have_docbook is "no"? Seems like that could save troubleshooting efforts like
the one referenced above. Commit 7267fdd7a3a did in fact include this in the
global Makefile but has been removed at some point (which I'm currently too
undercaffeinated to find).
cheers ./daniel