Re: Faster StrNCpy

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: Faster StrNCpy
Дата
Msg-id 29714.1159304039@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: Faster StrNCpy  (Martijn van Oosterhout <kleptog@svana.org>)
Ответы Re: Faster StrNCpy  (Neil Conway <neilc@samurai.com>)
Список pgsql-hackers
Martijn van Oosterhout <kleptog@svana.org> writes:
> I think that's why strlcpy was invented, to deal with the issues with
> strncpy.
> http://www.gratisoft.us/todd/papers/strlcpy.html

strlcpy does more than we need (note that none of the existing uses care
about counting the overflowed bytes).  Not sure if it's worth adopting
those semantics when they're not really standard, but if you think a lot
of people would be familiar with strlcpy, maybe we should.

> Do you really think it's worth making a macro rather than just a normal
> function?

Only in that a macro in c.h is less work than a configure test plus a
replacement file in src/port.  But if we want to consider this a
standard function that just doesn't happen to exist everywhere, I
suppose we should use configure.
        regards, tom lane


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Alvaro Herrera
Дата:
Сообщение: Re: Faster StrNCpy
Следующее
От: Neil Conway
Дата:
Сообщение: Re: Faster StrNCpy