Re: Replication slot stats misgivings

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: Replication slot stats misgivings
Дата
Msg-id 2957480.1619666400@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: Replication slot stats misgivings  (Amit Kapila <amit.kapila16@gmail.com>)
Ответы Re: Replication slot stats misgivings
Re: Replication slot stats misgivings
Список pgsql-hackers
Amit Kapila <amit.kapila16@gmail.com> writes:
> This is the first test and inserts just one small record, so how it
> can lead to spill of data. Do you mean to say that may be some
> background process has written some transaction which leads to a spill
> of data?

autovacuum, say?

> Yeah, something like this could happen. Another possibility here could
> be that before the stats collector has processed drop and create
> messages, we have enquired about the stats which lead to it giving us
> the old stats. Note, that we don't wait for 'drop' or 'create' message
> to be delivered. So, there is a possibility of the same. What do you
> think?

You should take a close look at the stats test in the main regression
tests.  We had to jump through *high* hoops to get that to be stable,
and yet it still fails semi-regularly.  This looks like pretty much the
same thing, and so I'm pessimistically inclined to guess that it will
never be entirely stable.

(At least not before the fabled stats collector rewrite, which may well
introduce some entirely new set of failure modes.)

Do we really need this test in this form?  Perhaps it could be converted
to a TAP test that's a bit more forgiving.

            regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Andres Freund
Дата:
Сообщение: Re: WIP: WAL prefetch (another approach)
Следующее
От: Tom Lane
Дата:
Сообщение: Re: WIP: WAL prefetch (another approach)