Re: GinPageIs* don't actually return a boolean

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: GinPageIs* don't actually return a boolean
Дата
Msg-id 29387.1439419979@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: GinPageIs* don't actually return a boolean  (Andres Freund <andres@anarazel.de>)
Ответы Re: GinPageIs* don't actually return a boolean  (Andres Freund <andres@anarazel.de>)
Список pgsql-hackers
Andres Freund <andres@anarazel.de> writes:
> I went through all headers in src/include and checked for macros
> containing [^&]&[^&] and checked whether they have this hazard. Found a
> fair number.

> That patch also changes !! tests into != 0 style.

Looks OK to me, except I wonder why you did this#define TRIGGER_FIRED_FOR_ROW(event) \
-    ((event) & TRIGGER_EVENT_ROW)
+    (((event) & TRIGGER_EVENT_ROW) == TRIGGER_EVENT_ROW)

rather than != 0.  That way doesn't look either more efficient or
more readable.
        regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Robert Haas
Дата:
Сообщение: Re: WIP: SCRAM authentication
Следующее
От: Andres Freund
Дата:
Сообщение: Re: GinPageIs* don't actually return a boolean