Hitoshi Harada <umi.tanuki@gmail.com> writes:
> 2010/3/17 Tom Lane <tgl@sss.pgh.pa.us>:
>> When we were doing the ordered-aggregates patch, I considered passing
>> all those values as explicit parameters to transformAggregateCall,
>> and having it build the Aggref node from scratch and return it.
>> However having seven or eight parameters to transformAggregateCall
>> (and more in future if we ever add more features here) didn't really
>> seem to be better style than abusing Aggref a bit. �But maybe it is
>> the best way after all. �Thoughts?
> Well, I think the point is args and aggorder are hidden in the Aggref
> passed to transformAggregateCall, although they will be transformed in
> the function. Isn't it enough to add more parameters for them
> (agg_distinct is passed separately) and to leave the Aggref pointer
> passing as present?
Yeah, that's probably the least complicated solution. Will fix.
regards, tom lane