Re: speedup tidbitmap patch: cache page

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: speedup tidbitmap patch: cache page
Дата
Msg-id 29303.1421428535@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: speedup tidbitmap patch: cache page  (Andres Freund <andres@2ndquadrant.com>)
Ответы Re: speedup tidbitmap patch: cache page  (Andres Freund <andres@2ndquadrant.com>)
Список pgsql-hackers
Andres Freund <andres@2ndquadrant.com> writes:
> On 2014-12-25 01:26:53 +1300, David Rowley wrote:
>> So I think v3 is the one to go with, and I can't see any problems with it,
>> so I'm marking it as ready for committer.

> And committed.

It strikes me that this patch leaves some lookups on the table,
specifically that it fails to avoid repeated hash_search lookups
inside tbm_page_is_lossy() in the situation where we're adding
new TIDs to an already-lossified page.  Is it worth adding a few
more lines to handle that case as well?
        regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Heikki Linnakangas
Дата:
Сообщение: Re: pg_rewind in contrib
Следующее
От: Pavel Stehule
Дата:
Сообщение: Re: proposal: searching in array function - array_position