Re: Use of $(THREAD_CFLAGS) in CPPFLAGS

Bruce Momjian <pgman@candle.pha.pa.us> writes:
> I just noticed that libpq/ecpg use $(THREAD_CFLAGS) as part of CPPFLAGS.
> Is that correct?  Should it be added to CFLAGS instead?

I was just noticing that today.  THREAD_CFLAGS typically includes -D
flags, and as such it *must* be added to CPPFLAGS --- it'd be incorrect
to add it to CFLAGS.  Possibly we should rename THREAD_CFLAGS to 
THREAD_CPPFLAGS.  I'm not sure that we have any platforms for which it
would be useful to invent both THREAD_CPPFLAGS and THREAD_CFLAGS.
        regards, tom lane