Re: [PATCH] Add tests for psql tab completion

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: [PATCH] Add tests for psql tab completion
Дата
Msg-id 2920743.1644868864@sss.pgh.pa.us
обсуждение исходный текст
Ответ на [PATCH] Add tests for psql tab completion  (Matheus Alcantara <mths.dev@pm.me>)
Список pgsql-hackers
Matheus Alcantara <mths.dev@pm.me> writes:
> I'm attaching a patch that add some new test cases for tab completion of psql.

What exactly is the motivation for these particular tests?

I believe that most of tab-complete.c is already covered, outside
of the giant if-else chain at the heart of psql_completion().
It's hard to summon interest in trying to cover every branch of
that chain; but if we're to add coverage of just a few more,
which ones and why?  The ones you've chosen to hit in this
patch don't seem especially interesting.

            regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: Time to drop plpython2?
Следующее
От: Robert Haas
Дата:
Сообщение: Re: [Proposal] Fully WAL logged CREATE DATABASE - No Checkpoints