Re: Use of PG_BINARY_R and "r"

Bruce Momjian <pgman@candle.pha.pa.us> writes:
> My assumption is that text files should use "r" and binary files use
> PG_BINARY_R.

I believe that's correct.  It seems kinda inconsistent though.

> For example, in 7.2 I see pg_hba.conf opened with "r" and pg_ident.conf
> opened with PG_BINARY_R.

The latter is clearly wrong, since pg_ident.conf is not binary.

Is there any interest in defining#define PG_TEXT_R "r"#define PG_TEXT_W "w"
so that AllocateFile is always called with one of this set of macros?
Or is that just silly?
        regards, tom lane