Re: [Review] Tests citext casts by David Wheeler.

"Ryan Bradetich" <rbradetich@gmail.com> writes:
> Here is my review of the Test citext casts written by David Wheeler:

Thanks for reviewing.  I've committed this with your suggestions and
one additional non-cosmetic change: schema-qualify names in the
bodies of the SQL functions so that they are not search_path dependent.

One thing that didn't make a lot of sense to me was the last new
function:

CREATE OR REPLACE FUNCTION translate( citext, citext, text ) RETURNS TEXT AS $$   SELECT pg_catalog.translate(
pg_catalog.translate($1::pg_catalog.text, pg_catalog.lower($2::pg_catalog.text), $3),
pg_catalog.upper($2::pg_catalog.text),$3);
 
$$ LANGUAGE SQL IMMUTABLE STRICT;

Why is it using upper()?
        regards, tom lane