On 08/26/2016 04:07 PM, Aleksander Alekseev wrote:
>> Another unrelated change in this patch is the addition of
>> rb_rightmost(). It's not used for anything, so I'm not sure what the
>> point is. Then again, there don't seem to be any callers of
>> rb_leftmost() either.
>
> It's just something I needed in tests to reach a good percent of code
> coverage. Implementation of rb_rightmost is trivial so we probably can do
> without it.
Looking closer, we don't currently use any of the iterators besides the
left-right iterator either. Nor rb_delete().
>> I think we should something like in the attached patch. It seems to pass
>> your test suite, but I haven't done any other testing on this. Does it
>> look OK to you?
>
> Looks good to me.
Ok, committed.
- Heikki