Re: Alpha test

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: Alpha test
Дата
Msg-id 28821.1072139133@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: Alpha test  (Bruce Momjian <pgman@candle.pha.pa.us>)
Ответы Re: Alpha test
Список pgsql-patches
Bruce Momjian <pgman@candle.pha.pa.us> writes:
> Tom Lane wrote:
>> example, we have *no* evidence to suggest that that NOFIXADE stuff in
>> main.c is needed on platforms that don't define __alpha.  I would tend
>> to take an "if it ain't broke don't fix it" approach, especially on
>> platforms we don't have handy to test.

> The problem was that certain cases tested for __alpha__ and some
> __alpha --- same with __sparc.

My point is that without testing, you have no way to know that that
variation is not correct, and perhaps even necessary.  Given that this
code has been through many releases already, I think the odds that you
are breaking something are higher than the odds that you are fixing
something.  I think you should leave well enough alone until we get an
actual bug report showing that there's a problem.

            regards, tom lane

В списке pgsql-patches по дате отправления:

Предыдущее
От: Bruce Momjian
Дата:
Сообщение: Re: Alpha test
Следующее
От: Bruce Momjian
Дата:
Сообщение: remove NEED_I386_TAS_ASM