Re: 42.2.3 regression in fn timestampadd(SQL_TSI_MINUTE)

Vladimir, thanks for the prompt fix!

I've confirmed that 42.2.4 works correctly with our unit tests (which 
exercise timestampadd using all the standard constants)... i.e., fix 
looks great.

Minor issue: I believe there's a typo in the 42.2.3 known issues section 
of the changelogs (/CHANGELOG.md and 
/docs/_posts/2018-07-12-42.2.3-release.md): I think "SQL_TSI_MINUTE is 
treated as minute" should be "SQL_TSI_MINUTE is treated as second".

Thanks!
Adam

On 7/14/2018 3:06 AM, Vladimir Sitnikov wrote:
> Adam, thanks for the prompt report.
>
> Please feel free to review a suggested fix: 
> https://github.com/pgjdbc/pgjdbc/pull/1250
>
> Vladimir