Re: Patch for fixing a few memory leaks

Teodor Sigaev <teodor@stack.net> writes:
> Patch fix memory leaks in src/backend/utils/fmgr/dfmgr.c .

Applied, thanks.  (Looks like the leaks were introduced fairly
recently by the dynamic-search-path feature.)

> Tom, I want to notice that initGISTstate is called for every inserting
> value (for each row). I think it's not good, because this function
> called 'fmgr_info' 7 times. 'fmgr_info' call a
> 'load_external_function' with execution of sequence search on library
> name. Any suggestion?

fmgr_info shouldn't be all that expensive; I'm not really inclined to
worry about it.  Do you have evidence to the contrary?
        regards, tom lane