Re: Optimizing numeric SUM() aggregate

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: Optimizing numeric SUM() aggregate
Дата
Msg-id 28450.1469622762@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: Optimizing numeric SUM() aggregate  (Andrew Borodin <borodin@octonica.com>)
Ответы Re: Optimizing numeric SUM() aggregate  (Andrew Borodin <borodin@octonica.com>)
Список pgsql-hackers
Andrew Borodin <borodin@octonica.com> writes:
>> I don't think there is any reason for this new code to assume NBASE=10000

> There is a comment on line 64 stating that value 10000 is hardcoded
> somewhere else, any other value is not recommended and a bunch of code
> is left for historical reasons.

Doesn't matter: please use NBASE when you mean NBASE.  10000 is just a
magic number, and therefore bad coding style.  For that matter, spelling
INT_MAX as 0x7FFFFFF is also not per project style.
        regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Craig Ringer
Дата:
Сообщение: Re: handling unconvertible error messages
Следующее
От: Vik Fearing
Дата:
Сообщение: Re: Why we lost Uber as a user