Re: fix_PGSTAT_NUM_TABENTRIES_macro patch

Mark Dilger <markdilger@yahoo.com> writes:
> I don't care for the places in the code that say things like

> ��� foo - sizeof(int)

> where "int" refers implicitly to a specific variable or struct field, but
> you have to remember that and change it by hand if you change the
> type of the variable or struct.

> But this sort of code is quite common in postgres, and not
> at all unique to src/include/pgstat.h.

Really?  I think we're using offsetof for this type of thing in most
places.
        regards, tom lane