Re: hyrax versus isolationtester.c's hard-wired timeouts

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: hyrax versus isolationtester.c's hard-wired timeouts
Дата
Msg-id 28259.1575920069@sss.pgh.pa.us
обсуждение исходный текст
Ответ на hyrax versus isolationtester.c's hard-wired timeouts  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
I wrote:
> There are two things we could do about this:
> 1. Knock the hard-wired setting up a tad, maybe to 5 minutes.
> Easy but doesn't seem terribly future-proof.
> 2. Make the limit configurable somehow, probably from an
> environment variable.  There's precedent for that (PGCTLTIMEOUT),
> and it would provide a way for owners of especially slow buildfarm
> members to adjust things ... but it would require owners of
> especially slow buildfarm animals to adjust things.
> Any preferences?  (Actually, it wouldn't be unreasonable to do
> both things, I suppose.)
> BTW, I notice that isolationtester.c fails to print any sort of warning
> notice when it decides it's waited too long.  This seems like a
> spectacularly bad idea in hindsight: it's not that obvious why the test
> case failed.  Plus there's no way to tell exactly which connection it
> decided to send a PQcancel to.  So independently of the timeout-length
> issue, I think we ought to also make it print something like
> "isolationtester: waited too long for something to happen, canceling
> step thus-and-so".

I pushed a patch doing all of the above.  This should be enough to
fix hyrax's problem without any manual adjustments of the animal's
configuration ... unless I've misdiagnosed what's happening.
We shall see.

            regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: log bind parameter values on error
Следующее
От: Alvaro Herrera
Дата:
Сообщение: Re: log bind parameter values on error