Re: Experimenting with hash tables inside pg_dump

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: Experimenting with hash tables inside pg_dump
Дата
Msg-id 2824534.1634934759@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: Experimenting with hash tables inside pg_dump  (Tom Lane <tgl@sss.pgh.pa.us>)
Ответы Re: Experimenting with hash tables inside pg_dump  (Andres Freund <andres@anarazel.de>)
Список pgsql-hackers
I wrote:
> Andres Freund <andres@anarazel.de> writes:
>> Wonder if we should mark simplehash's grow as noinline? Even with a single caller it seems better to not inline it
toremove register allocator pressure. 

> Seems plausible --- you want me to go change that?

Hmm, harder than it sounds.  If I remove "inline" from SH_SCOPE then
the compiler complains about unreferenced static functions, while
if I leave it there than adding pg_noinline causes a complaint about
conflicting options.  Seems like we need a less quick-and-dirty
approach to dealing with unnecessary simplehash support functions.

            regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Jeff Davis
Дата:
Сообщение: Re: add retry mechanism for achieving recovery target before emitting FATA error "recovery ended before configured recovery target was reached"
Следующее
От: Daniel Gustafsson
Дата:
Сообщение: Re: [PATCH] Fix memory corruption in pg_shdepend.c