Re: BUG #4879: bgwriter fails to fsync the file in recovery mode

I wrote:
> Heikki Linnakangas <heikki.linnakangas@enterprisedb.com> writes:
>> Hmm, I see another small issue. We now keep track of the "minimum
>> recovery point". Whenever a data page is flushed, we set minimum
>> recovery point to the LSN of the page in XLogFlush(), instead of
>> fsyncing WAL like we do in normal operation.

> We would want the end-of-recovery checkpoint to act like it's not in
> recovery anymore for this purpose, no?

Actually, what in the world is the purpose of that code at all?
I can't see a case where it would trigger that wouldn't be a result
of data corruption rather than a real need to advance the min restart
point.

            regards, tom lane