Re: log chunking broken with large queries under load

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: log chunking broken with large queries under load
Дата
Msg-id 27776.1333555990@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: log chunking broken with large queries under load  (Andrew Dunstan <andrew@dunslane.net>)
Ответы Re: log chunking broken with large queries under load  (Andrew Dunstan <andrew@dunslane.net>)
Список pgsql-hackers
Andrew Dunstan <andrew@dunslane.net> writes:
> On 04/02/2012 01:03 PM, Tom Lane wrote:
>> When I said "list", I meant a "List *".  No fixed size.

> Ok, like this?

I think this could use a bit of editorialization (I don't think the
"stripe" terminology is still applicable, in particular), but the
general idea seems OK.

Does anyone feel that it's a bad idea that list entries are never
reclaimed?  In the worst case a transient load peak could result in
a long list that permanently adds search overhead.  Not sure if it's
worth the extra complexity to delete a list cell that's no longer
needed, rather than leaving it present and empty.

> Do we consider this a bug fix, to be backpatched?

Yes, definitely.

I think I'd like to have a go at coding it the other way (with
release of list entries), just to see if that comes out cleaner
or uglier than this way.  If you don't mind I'll pick this up
and commit whichever way turns out better.
        regards, tom lane


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Scott Mead
Дата:
Сообщение: Re: invalid search_path complaints
Следующее
От: Heikki Linnakangas
Дата:
Сообщение: Re: poll: CHECK TRIGGER?