Re: Uninitialized scalar variable (UNINIT) (src/backend/statistics/extended_stats.c)

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: Uninitialized scalar variable (UNINIT) (src/backend/statistics/extended_stats.c)
Дата
Msg-id 2749674.1618207453@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: Uninitialized scalar variable (UNINIT) (src/backend/statistics/extended_stats.c)  (Michael Paquier <michael@paquier.xyz>)
Ответы Re: Uninitialized scalar variable (UNINIT) (src/backend/statistics/extended_stats.c)
Список pgsql-hackers
Michael Paquier <michael@paquier.xyz> writes:
> On Sun, Apr 11, 2021 at 07:42:20PM -0300, Ranier Vilela wrote:
>> Em dom., 11 de abr. de 2021 às 16:25, Justin Pryzby <pryzby@telsasoft.com>
>>> I think it's cleanest to write:
>>> |HeapTupleData tmptup = {0};

> I agree that this would be cleaner.

It would be wrong, though, or at least not have the same effect.
ItemPointerSetInvalid does not set the target to all-zeroes.

(Regardless of that detail, it's generally best to accomplish
objective X in the same way that existing code does.  Deciding
that you have a better way is often wrong, and even if you
are right, you should then submit a patch to change all the
existing cases.)

            regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Bharath Rupireddy
Дата:
Сообщение: Re: Simplify backend terminate and wait logic in postgres_fdw test
Следующее
От: Michael Paquier
Дата:
Сообщение: Problems around compute_query_id