Re: pg_upgrade from 8.3.4 issue

I wrote:
> I think it'd be a lot safer to modify (or just remove) the test in
> pg_upgrade.  It looks like a one-liner:

Specifically, the attached patch takes care of the problem.  Thanks
for reporting it!

            regards, tom lane


diff --git a/contrib/pg_upgrade/check.c b/contrib/pg_upgrade/check.c
index 9690695..93b9e69 100644
*** a/contrib/pg_upgrade/check.c
--- b/contrib/pg_upgrade/check.c
*************** check_for_prepared_transactions(ClusterI
*** 532,538 ****

      res = executeQueryOrDie(conn,
                              "SELECT * "
!                             "FROM pg_catalog.pg_prepared_xact()");

      if (PQntuples(res) != 0)
          pg_log(PG_FATAL, "The %s cluster contains prepared transactions\n",
--- 532,538 ----

      res = executeQueryOrDie(conn,
                              "SELECT * "
!                             "FROM pg_catalog.pg_prepared_xacts");

      if (PQntuples(res) != 0)
          pg_log(PG_FATAL, "The %s cluster contains prepared transactions\n",