Robert Haas <robertmhaas@gmail.com> writes:
> On Thu, May 18, 2017 at 2:37 AM, Heikki Linnakangas <hlinnaka@iki.fi> wrote:
>> I still don't think this worth it to change the hook function's signature
>> for this. Even though it's not a big deal for external modules to adapt,
>> it's not zero effort either. And it's not that much nicer to us.
> I favor committing the proposed patch. Otherwise, it just becomes
> pointless baggage that we carry forever.
> Anyone else want to vote? So far I count 3-1 in favor of making this change.
Actually, on looking at the final form of the patch, it's hard to think
that it's not just useless API churn. The one existing hook user would
have to turn around and call get_password_type() anyway, so it's not
an improvement for that use-case. What's the argument that most other
use-cases wouldn't need to do the same?
regards, tom lane