Re: [PATCH] ruleutils: Fix subqueries with shadowed aliases

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: [PATCH] ruleutils: Fix subqueries with shadowed aliases
Дата
Msg-id 27275.1560383173@sss.pgh.pa.us
обсуждение исходный текст
Ответ на [PATCH] ruleutils: Fix subqueries with shadowed aliases  (Philip Dubé <Philip.Dub@microsoft.com>)
Список pgsql-hackers
=?iso-8859-1?Q?Philip_Dub=E9?= <Philip.Dub@microsoft.com> writes:
> Discovered while looking into issue here: https://github.com/citusdata/citus/pull/2733
> For completeness I'll quote the example code to demonstrate the issue:
> ...
> Where the 2nd join_alias should be renamed to join_alias_1

Good catch!  The proposed test case is less good though, because
it doesn't actually exercise the bug, ie the test case passes
with or without the code change.  (You also stuck it into the
middle of a bunch of not-very-related test cases.)  I adapted
your example into a better test case and pushed it.  Thanks
for the report and fix.

            regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: David Rowley
Дата:
Сообщение: Re: Should we warn against using too many partitions?
Следующее
От: Tomas Vondra
Дата:
Сообщение: Re: Adaptive query optimization