Re: minor auth code cleanup

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: minor auth code cleanup
Дата
Msg-id 27027.1030461339@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: minor auth code cleanup  (Neil Conway <neilc@samurai.com>)
Ответы Re: minor auth code cleanup  (Bruce Momjian <pgman@candle.pha.pa.us>)
Список pgsql-patches
Neil Conway <neilc@samurai.com> writes:
>> There may be existing clients out there that miscompute the password
>> packet length.  Right now that does no harm.  With an Assert in place
>> in the backend, it will cause a database system restart.

> Good point. However, I still think a sanity check would be appropriate
> here. How about an elog(WARNING) ?

I think that elog(LOG) is probably the right thing.  IIRC, at that point
in startup we will not send anything short of ERROR to the client, so
elog(WARNING) is pointless from the client's point of view --- and a LOG
is actually more likely to get into the server's log than a WARNING.

            regards, tom lane

В списке pgsql-patches по дате отправления:

Предыдущее
От: Bruce Momjian
Дата:
Сообщение: Re: minor auth code cleanup
Следующее
От: Bruce Momjian
Дата:
Сообщение: Re: minor auth code cleanup