Re: [patch] fix dblink security hole

Joe Conway <mail@joeconway.com> writes:
> Maybe better:

> static PQconninfoOption *
> conninfo_parse(const char *conninfo, PQExpBuffer errorMessage,
>                 bool fill_defaults, bool *password_from_string)

I'm thinking a separate conninfo_fill_defaults function is better,
though it's not a big deal.

What do you think about getting rid of the password_from_string state
variable?  It was always a bit of a kluge, and we don't seem to need
it anymore with this approach.
        regards, tom lane