Re: performance bug in instrument.c

Tomas Vondra <tv@fuzzy.cz> writes:
> Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> A bigger question is why this is elog(DEBUG2) and not elog(ERROR).
>> Had it been the latter, we'd have noticed the mistake immediately.
>> The current choice might be masking any caller-logic errors that
>> exist, too.

> Not sure why it's DEBUG2, but if it really is an error then it should be
> logged as ERROR I guess.

Perhaps there was a reason for that once, but AFAICT the logic is clean
now.  I changed these elogs to ERROR and ran all the regression tests
under auto_explain, and nothing failed.  That's hardly conclusive of
course, but it's enough evidence to persuade me to make the change in
HEAD.
        regards, tom lane