Re: client_encoding directive is ignored in postgresql.conf

Tatsuo Ishii <t-ishii@sra.co.jp> writes:
> + /* Flag to we need to initialize client encoding info */
> + static bool need_to_init_client_encoding = -1;

Surely that should be int, not bool.

> !                     if (!PQsendQuery(conn, "begin; select pg_client_encoding(); commit"))

Doesn't this break compatibility with pre-7.2 databases?  AFAICT that
function was introduced in 7.2.
        regards, tom lane