Re: Bug #925: typing error in src/backend/libpq/be-secure.c

Bruce Momjian <pgman@candle.pha.pa.us> writes:
> Yep, typo.  Patched to CVS current and backpatched to 7.3.X.

I think this fix is exactly backward.  Why would SSL_write need to
return ERROR_WANT_WRITE?  It couldn't.  The correct fix is that
SSL_write might return ERROR_WANT_READ, for which reading would be
the right response.

BTW the real problem, both here and elsewhere in this file, is the
lack of a "default: elog-out" case in the switch statements.  This
code will simply break if any unexpected case occurs.

            regards, tom lane