Re: [PATCHES] Cygwin PostgreSQL ESQL Patch

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: [PATCHES] Cygwin PostgreSQL ESQL Patch
Дата
Msg-id 26867.987785010@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Cygwin PostgreSQL ESQL Patch  (Jason Tishler <Jason.Tishler@dothill.com>)
Ответы Re: [PATCHES] Cygwin PostgreSQL ESQL Patch
Список pgsql-cygwin
Jason Tishler <Jason.Tishler@dothill.com> writes:
> --- include/sqlca.h    2001/03/22 06:16:20    1.16
> +++ include/sqlca.h    2001/04/20 14:15:01
> @@ -1,6 +1,12 @@
>  #ifndef POSTGRES_SQLCA_H
>  #define POSTGRES_SQLCA_H

> +#ifdef __CYGWIN__
> +#define DLLIMPORT __declspec (dllimport)
> +#else
> +#define DLLIMPORT
> +#endif /* __CYGWIN__ */
> +
>  #define SQLERRMC_LEN    70

This seems rather bad --- why should sqlca.h define this symbol?  What
happens if sqlca.h is included in a file that also includes other
Postgres includes, which will probably pull in c.h where the real
definition is?  I'd suggest adding

    #include "postgres_ext.h"
    #include "c.h"

instead, which may be more namespace pollution than we'd like, but
at least it does not create a potential definition conflict.

            regards, tom lane

В списке pgsql-cygwin по дате отправления:

Предыдущее
От: Jason Tishler
Дата:
Сообщение: Re: initdb fails
Следующее
От: Jason Tishler
Дата:
Сообщение: Re: [PATCHES] Cygwin PostgreSQL ESQL Patch