Re: Function to track shmem reinit time

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: Function to track shmem reinit time
Дата
Msg-id 26728.1582390905@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: Function to track shmem reinit time  (Alexander Korotkov <a.korotkov@postgrespro.ru>)
Ответы Re: Function to track shmem reinit time
Re: Function to track shmem reinit time
Список pgsql-hackers
Alexander Korotkov <a.korotkov@postgrespro.ru> writes:
> From my point of view criticism of this patch was addressed by
> argument, that pg_shmem_init_time() allows to calculate the server
> uptime [1].  This is very basic information, which is reasonable to
> get without log files parsing.  It's more than year since [1] is
> unanswered.  So, I'm going to push this if no objections.

I'm still going to object to it, on the grounds that

(1) it's exposing an implementation detail that clients should not be
concerned with, and that we might change in future.  The name isn't
even well chosen --- if the argument is that it's useful to monitor
server uptime, why isn't the name "pg_server_uptime"?

(2) if your server is crashing often enough that postmaster start
time isn't an adequate substitute, you have way worse problems than
whether you can measure it.  I'd rather see us put effort into
fixing whatever the underlying problem is.

            regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Alexander Korotkov
Дата:
Сообщение: Re: Function to track shmem reinit time
Следующее
От: Alexander Korotkov
Дата:
Сообщение: Re: Function to track shmem reinit time