Re: PL/R regression on windows, but not linux with master.

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: PL/R regression on windows, but not linux with master.
Дата
Msg-id 2667316.1618150403@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: PL/R regression on windows, but not linux with master.  (Andrew Dunstan <andrew@dunslane.net>)
Ответы Re: PL/R regression on windows, but not linux with master.
Список pgsql-hackers
Andrew Dunstan <andrew@dunslane.net> writes:
>> Well, plr.h does this:
>> 
>> #define WARNING        19
>> #define ERROR        20

> The coding pattern in plr.h looks quite breakable. Instead of hard
> coding values like this they should save the value from the postgres
> headers in another variable before undefining it and then restore that
> value after inclusion of the R headers.

Indeed.  elog.h already provides a "PGERROR" macro to use for restoring
the value of ERROR.  We have not heard of a need to do anything special
for WARNING though --- maybe that's R-specific?

            regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Zhihong Yu
Дата:
Сообщение: Re: Add header support to text format and matching feature
Следующее
От: Rémi Lapeyre
Дата:
Сообщение: Re: Add header support to text format and matching feature