On 2019/03/07 22:54, Robert Haas wrote:
> On Thu, Mar 7, 2019 at 7:35 AM Etsuro Fujita
> <fujita.etsuro@lab.ntt.co.jp> wrote:
>> Thanks for the patch!
>>
>> The patch looks good to me, but one thing I'm wondering is: as suggested
>> by David, it would be better to rephrase this mention in the UPDATE
>> reference page, in a single commit:
>>
>> "Currently, rows cannot be moved from a partition that is a foreign
>> table to some other partition, but they can be moved into a foreign
>> table if the foreign data wrapper supports it."
>>
>> I don't think it needs to be completely rephrased; it's enough for me to
>> rewrite it to something like this:
>>
>> "Currently, rows cannot be moved from a foreign-table partition to some
>> other partition, but they can be moved into a foreign-table partition if
>> the foreign data wrapper supports tuple routing."
>
> I prefer David's wording.
IIUC, David's suggestion [1] is to change the existing wording, which he
found hard to parse, to something like Fujita-san is suggesting.
Thanks,
Amit
[1]
https://www.postgresql.org/message-id/CAKJS1f-SauQJftjcaQ7C_tzHh_be5C8shT-E9qYnVp%2Bjh4-Fww%40mail.gmail.com