Re: initdb / bootstrap design

On 16.02.22 03:12, Andres Freund wrote:
> Sure, there's a few tokens that we replace in initdb. As it turns out there's
> only two rows that are actually variable. The username of the initial
> superuser in pg_authid and the pg_database row for template 1, where encoding,
> lc_collate and lc_ctype varies. The rest is all compile time constant
> replacements we could do as part of genbki.pl.
> 
> It seems we could save a good number of context switches by opening
> postgres.bki just before boot_yyparse() in BootstrapModeMain() and having the
> parser read it.  The pg_authid / pg_database rows we could just do via
> explicit insertions in BootstrapModeMain(), provided by commandline args?

I think we could do the locale setup by updating the pg_database row of 
template1 after bootstrap, as in the attached patch.  (The order of 
proceedings in the surrounding function might need some refinement in a 
final patch.)  I suspect we could do the treatment of pg_authid similarly.