Re: pgsql: Allow pg_basebackup to stream transaction log in tar mode

Magnus Hagander <magnus@hagander.net> writes:
> The remaining windows buildfarm build issue looks like this:
>   src/bin/pg_basebackup/receivelog.c(135): error C2039: '_commit' : is
> not a member of 'WalWriteMethod'
> [C:\buildfarm\buildenv\HEAD\pgsql.build\pg_basebackup.vcxproj]
> AFAICT this comes from using walmethod->fsync(), and we have a #define
> changing fsync() to _commit (port/win32.h, line 70).

Yeah.

> The easiest might just be to rename walmethod->fsync() to
> walmethod->do_fsync(), so we don't have to mess with any other code.

How about calling the method just "sync()"?  Seems a bit less
artificial.

            regards, tom lane