Re: pgsql: Drop test user when done with it.

Michael Paquier <michael@paquier.xyz> writes:
> On Mon, Jun 24, 2019 at 04:37:13PM +0000, Tom Lane wrote:
>> Commit d7f8d26d9 added a test case that created a user, but forgot
>> to drop it again.  This is no good; for one thing, it causes repeated
>> "make installcheck" runs to fail.

> If we are on that, we still have src/test/modules/test_pg_dump/ which
> is not repeatable with multiple installchecks:
> https://www.postgresql.org/message-id/20181130163728.GE3415@tamriel.snowman.net

OK, hadn't run into that personally, but let's fix that too.  Anything
that can be run with "installcheck" has to satisfy the restrictions
of being re-runnable and careful about what global names it uses.

            regards, tom lane