Re: avg(int2) and avg(int8) micro-opt

Neil Conway <neilc@samurai.com> writes:
> This patch changes int2_avg_accum() and int4_avg_accum() use the nodeAgg
> performance hack Tom introduced recently.

Why only those two?  Might as well make all the accum functions look alike.

> It is possible that the transition array might be TOAST'ed (not that I'd
> expect that to occur in practice, of course).

AFAICS that is impossible, since the transition value is never stored to
disk.  But your analysis is good anyway.

            regards, tom lane