Re: Modification to the postgres catalog

"Carlos Chacon" <cdcarloschacon@gmail.com> writes:
> HI... im trying to modify the pg_class table by adding a new
> attribute.

> - include/pg_class.h: in this file, i modfify:

Did you remember to update Natts_pg_class and the Anum_ macros?

>  then, i modify the macro "CLASS_TUPLE_SIZE":
>     #define CLASS_TUPLE_SIZE \
>      (offsetof(FormData_pg_class,relhassubclass) + sizeof(bool) +
> sizeof(bool))   /* the last bool is my bool */

Seriously ugly, should use offsetof the last attribute, ie, yours.

Also, look at the uses of Natts_pg_class_fixed --- there was some
cruftiness involved there in existing releases (it's gone in HEAD
and I'm too lazy to look back at exactly what it was...)
        regards, tom lane