Re: pgsql: Improve handling of NULLs in KNN-GiST and KNN-SP-GiST

Erik Rijkers <er@xs4all.nl> writes:
> Oops:
>       create_index                 ... ok          634 ms
>       create_index_spgist          ... FAILED      438 ms
>       create_view                  ... ok          329 ms

I'm betting the issue is breaking the Datum abstraction here:

-                   scan->xs_orderbyvals[i] = Float8GetDatum(distanceValues[i]);
+                   scan->xs_orderbyvals[i] = item->distances[i].value;

AFAICS, item->distances[i].value is a double not a Datum, so dropping
the Float8GetDatum call is just wrong.

            regards, tom lane