Re: checksum_impl.h fails cpluspluscheck

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: checksum_impl.h fails cpluspluscheck
Дата
Msg-id 26025.1372565039@sss.pgh.pa.us
обсуждение исходный текст
Ответ на checksum_impl.h fails cpluspluscheck  (Peter Eisentraut <peter_e@gmx.net>)
Список pgsql-hackers
Peter Eisentraut <peter_e@gmx.net> writes:
> ./src/include/storage/checksum_impl.h: In function �uint32 pg_checksum_block(char*, uint32)�:
> ./src/include/storage/checksum_impl.h:154: warning: comparison between signed and unsigned integer expressions

> We could exclude that file from the check, but it's also easy to fix by
> making the variables unsigned:
> ...
> Preferences?

Possibly use uint32 for consistency with the other vars in the function?
No real objection to unsigned int, though, since it's the same thing in
practice.
        regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Peter Eisentraut
Дата:
Сообщение: checksum_impl.h fails cpluspluscheck
Следующее
От: Peter Geoghegan
Дата:
Сообщение: Re: checksum_impl.h fails cpluspluscheck