Re: Indentation in a patch

Поиск
Список
Период
Сортировка
От Daniel Gustafsson
Тема Re: Indentation in a patch
Дата
Msg-id 2595B96D-0A6E-472D-964A-8E87EC3B1C6B@yesql.se
обсуждение исходный текст
Ответ на Indentation in a patch  (Bernice Southey <bernice.southey@gmail.com>)
Ответы Re: Indentation in a patch
Список pgsql-general
> On 25 Nov 2025, at 19:14, Bernice Southey <bernice.southey@gmail.com> wrote:

> .. for my first ever patch attempt.

Awesome, we love to see new contributors!

> I'm tempted to submit my patch without indenting the
> if-block, and an explanation.

That's perfectly fine, an incorrectly indentend diff is fine to submit if it
makes it more readable (especially when coupled with a note explaining why).

> While I'm asking, I added a regression test and ran make check-world
> with the TAP tests. Anything else I should do before sending it to
> hackers?

Sounds like you've completed all the required steps.

--
Daniel Gustafsson




В списке pgsql-general по дате отправления: