Re: hstore ==> and deprecate =>

Robert Haas <robertmhaas@gmail.com> writes:
> +    if (!strcmp(oprName, "=>"))

BTW, project standard is to spell that like

> +    if (strcmp(oprName, "=>") == 0)

The other way looks confusingly like a "not equal" test.

> +                (errmsg("The use of => as an operator name is deprecated and may be disallowed in a future
release.")));

Also, this doesn't follow message style guidelines.  Possibly better:
errmsg("=> is deprecated as an operator name"),errdetail("This name may be disallowed altogether in future versions of
PostgreSQL.")
        regards, tom lane