Re: PATCH: pgbench / int64 instead of int for xact count

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: PATCH: pgbench / int64 instead of int for xact count
Дата
Msg-id 25618.1401050198@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: PATCH: pgbench / int64 instead of int for xact count  (Tomas Vondra <tv@fuzzy.cz>)
Список pgsql-hackers
Tomas Vondra <tv@fuzzy.cz> writes:
> Should we change the type of nxacts to int64 (thus allowing '-t' with
> 64-bit integers), or just the overflow in the printf call? I don't find
> it very practical to use -t with values not fitting into 32-bits (the -T
> seems better to do that), so I'm inclined to just fix the printf.

I concur: I don't see people setting -t higher than INT_MAX, but a -t
times -c product exceeding INT_MAX seems more plausible.

> Patch v3 attached.

Looks good, pushed.
        regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: David Fetter
Дата:
Сообщение: Re: IMPORT FOREIGN SCHEMA statement
Следующее
От: Tom Lane
Дата:
Сообщение: Re: Sending out a request for more buildfarm animals?