Re: Small fix for inv_getsize

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: Small fix for inv_getsize
Дата
Msg-id 25612.973183778@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Small fix for inv_getsize  (Denis Perchine <dyp@perchine.com>)
Ответы Re: Small fix for inv_getsize  (Denis Perchine <dyp@perchine.com>)
Список pgsql-patches
Denis Perchine <dyp@perchine.com> writes:
> Just realized that inv_getsize is a little bit wrong :-)). It just get the
> first page, not last
> Here is the patch which will fix the behavior.

No it doesn't; it's a loop, and your patch will change nothing.  Your
original version tried to stop after fetching one tuple, which was
wrong because of visibility considerations.

Now that I think about it, this code could do a two-key scan backwards
and stop after finding the first (last) valid tuple, but that's more
than a one-line change.

            regards, tom lane

В списке pgsql-patches по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: Patches for REL7_0_PATCHES
Следующее
От: Denis Perchine
Дата:
Сообщение: Re: Small fix for inv_getsize