Re: pgsql: Move pg_dump memory routines into pg_dumpmem.c/h and restore com

Andrew Dunstan <andrew@dunslane.net> writes:
> MSVC is still broken with this change, but now I think we've exposed a
> long-standing error in the MSVC build system. ...
> AddSimpleFrontend() calls AddDir() which harvests the contents of
> $(OBJS) from the Makefile for the target. But pg_dumpall doesn't want
> $(OBJS). We've been benignly but mistakenly building it with them for a
> quite a few years, but now we can't do that any more, given Bruce's
> changes. It looks like the fix is to call AddProject() for pg_dumpall
> instead of AddSimpleFrontend() and then do a little more work ourselves
> to select exactly what we need.

Maybe it would be better to refactor the makefile so that $(OBJS) is
still sensible to use this way?

            regards, tom lane