Re: pgsql: Move pg_dump memory routines into pg_dumpmem.c/h and restore com

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: pgsql: Move pg_dump memory routines into pg_dumpmem.c/h and restore com
Дата
Msg-id 25134.1322415779@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: pgsql: Move pg_dump memory routines into pg_dumpmem.c/h and restore com  (Andrew Dunstan <andrew@dunslane.net>)
Ответы Re: pgsql: Move pg_dump memory routines into pg_dumpmem.c/h and restore com
Список pgsql-committers
Andrew Dunstan <andrew@dunslane.net> writes:
> MSVC is still broken with this change, but now I think we've exposed a
> long-standing error in the MSVC build system. ...
> AddSimpleFrontend() calls AddDir() which harvests the contents of
> $(OBJS) from the Makefile for the target. But pg_dumpall doesn't want
> $(OBJS). We've been benignly but mistakenly building it with them for a
> quite a few years, but now we can't do that any more, given Bruce's
> changes. It looks like the fix is to call AddProject() for pg_dumpall
> instead of AddSimpleFrontend() and then do a little more work ourselves
> to select exactly what we need.

Maybe it would be better to refactor the makefile so that $(OBJS) is
still sensible to use this way?

            regards, tom lane

В списке pgsql-committers по дате отправления:

Предыдущее
От: Andrew Dunstan
Дата:
Сообщение: Re: pgsql: Move pg_dump memory routines into pg_dumpmem.c/h and restore com
Следующее
От: Tom Lane
Дата:
Сообщение: pgsql: Use the proper macro to convert a bool to a Datum.