Re: Bug in reindexdb's error reporting

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: Bug in reindexdb's error reporting
Дата
Msg-id 25087.1557499430@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: Bug in reindexdb's error reporting  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Ответы Re: Bug in reindexdb's error reporting  (Julien Rouhaud <rjuju123@gmail.com>)
Список pgsql-hackers
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> On 2019-May-10, Julien Rouhaud wrote:
>> I just noticed that reindexdb could report an extraneous message
>> saying an error happened while reindexing a database if it failed
>> reindexing a table or an index.

> Kudos, good find -- that's a 14 years old bug, introduced in this commit:

Yeah :-(.

Patch is good as far as it goes, but I wonder if it'd be smarter to
convert the function's "type" argument from a string to an enum,
and then replace the if/else chains with switches?

            regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Alvaro Herrera
Дата:
Сообщение: Re: att_isnull
Следующее
От: Tom Lane
Дата:
Сообщение: Re: att_isnull